Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl core::error::Error for Error #29

Merged
merged 3 commits into from
Oct 2, 2024
Merged

impl core::error::Error for Error #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c7ecfb
impl core::error::Error for Error
jordens Oct 1, 2024
71fc02f
feature gate core::error
jordens Oct 2, 2024
2fe6c19
use rustversion to gate core::error
jordens Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

* For `Runner::input_byte` the buffer `B` does not need to be `Sized`

### Added

* `impl core::error::Error for Error` on rust >= 1.81

## [v0.6.0] - 2024-08-30

### Changed
Expand Down
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ readme = "README.md"
[dependencies]
embedded-io = "0.6.1"
noline = { version = "0.5.0", optional = true }
rustversion = "1.0.17"

[features]
default = ["echo"]
Expand Down
9 changes: 9 additions & 0 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,15 @@ pub enum Error {
NotFound,
}

impl core::fmt::Display for Error {
fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
core::fmt::Debug::fmt(self, f)
}
}

#[rustversion::since(1.81)]
impl core::error::Error for Error {}

/// Looks for the named parameter in the parameter list of the item, then
/// finds the correct argument.
///
Expand Down