Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #134

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Fix warnings #134

merged 2 commits into from
Jun 6, 2024

Conversation

thejpster
Copy link
Member

Cleans up some clippy warnings

Closes #129

thejpster added 2 commits June 1, 2024 20:32
Notes that converting a byte to a char is assuming the the file is ISO-8859-1 encoded.
@thejpster thejpster requested review from eldruin and ryan-summers June 6, 2024 09:53
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eldruin eldruin added this pull request to the merge queue Jun 6, 2024
Merged via the queue into develop with commit ee72ddc Jun 6, 2024
8 checks passed
@thejpster thejpster deleted the fix-warnings branch June 6, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning: field 0 is never read
2 participants