Add a little shell example. #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can walk around a disk image and do directory listings. I had to make some more things 'Debug' so I could print the filesystem state. Also our handling of ".." was not right so I fixed that.
thejpster
force-pushed
the
add-shell
branch
from
c1b9e2f to
1a8cafd
Compare
eldruin
reviewed
Sep 25, 2023
Fixes the build.
Also moved the code into a method so we can use ?. Although ? is a pain when your objects cannot safely be dropped.
thejpster
changed the title
|
@eldruin added as requested. Should be ready now. |
Merged
ryan-summers
approved these changes
Oct 9, 2023
| } | ||
|
|
||
| fn process_line(&mut self, line: &str) -> Result<(), Error<std::io::Error>> { | ||
| if line == "help" { |
There was a problem hiding this comment.
FYI, https://docs.rs/logos/latest/logos/ is really nice for things like this :)
There was a problem hiding this comment.
Interesting! I'll check it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can walk around a disk image and do directory listings. I had to make some more things 'Debug' so I could print the filesystem state. Also our handling of ".." was not right so I fixed that.