revert to for-loops in get_x_by_id and change doc for File::close() t…

…o reflect behavior Drop impl.

src/filesystem/files.rs

@@ -131,9 +131,8 @@ where
 
     /// Consume the `File` handle and close it. The behavior of this is similar
     /// to using [`core::mem::drop`] or letting the `File` go out of scope,
-    /// except if the file fails to close properly, this returns an error,
-    /// whereas the automatic drop will panic. This method is therefore hihgly
-    /// recommended for closing files over just dropping them.
+    /// except this lets the user handle any errors that may occur in the process,
+    /// whereas when using drop, any errors will be discarded silently.
     pub fn close(self) -> Result<(), Error<D::Error>> {
         self.volume_mgr.close_file(self.raw_file)
     }

src/volume_mgr.rs

@@ -1015,30 +1015,30 @@ where
     }
 
     fn get_volume_by_id(&self, volume: RawVolume) -> Result<usize, Error<D::Error>> {
-        self.open_volumes
-            .iter()
-            .enumerate()
-            .find(|(_, v)| v.volume_id == volume)
-            .ok_or(Error::BadHandle)
-            .map(|(idx, _)| idx)
+        for (idx, v) in self.open_volumes.iter().enumerate() {
+            if v.volume_id == volume {
+                return Ok(idx);
+            }
+        }
+        Err(Error::BadHandle)
     }
 
     fn get_dir_by_id(&self, directory: RawDirectory) -> Result<usize, Error<D::Error>> {
-        self.open_dirs
-            .iter()
-            .enumerate()
-            .find(|(_, d)| d.directory_id == directory)
-            .ok_or(Error::BadHandle)
-            .map(|(idx, _)| idx)
+        for (idx, d) in self.open_dirs.iter().enumerate() {
+            if d.directory_id == directory {
+                return Ok(idx);
+            }
+        }
+        Err(Error::BadHandle)
     }
 
     fn get_file_by_id(&self, file: RawFile) -> Result<usize, Error<D::Error>> {
-        self.open_files
-            .iter()
-            .enumerate()
-            .find(|(_, f)| f.file_id == file)
-            .ok_or(Error::BadHandle)
-            .map(|(idx, _)| idx)
+        for (idx, f) in self.open_files.iter().enumerate() {
+            if f.file_id == file {
+                return Ok(idx);
+            }
+        }
+        Err(Error::BadHandle)
     }
 
     /// This function turns `desired_offset` into an appropriate block to be