-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Book into main repo #775
Merge Book into main repo #775
Conversation
Add initial book
Update types.md
Overhaul docs
Co-authored-by: Manish Goregaokar <[email protected]>
Backend guide
demo_gen Documentation
Adding documentation for custom functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but we should update CI
book/.github/workflows/build.yml
Outdated
@@ -0,0 +1,29 @@ | |||
name: build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this file should be moved to the top level
perhaps, book-deploy.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and then updated so that it runs in a folder
book/LICENSE
Outdated
@@ -0,0 +1,242 @@ | |||
Diplomat is licensed under the Apache License, Version 2.0 (included below) or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: i'd remove the license files
Also the nanobind commit made its way into this PR |
42bd6dd
to
90f0d61
Compare
Looks like there's some kind of glibc issue with the github setup? I'm not super familiar with github actions |
Should be fixed by rebasing, but close/open also works |
Oh I see the problem. you'll need to copy over the fix from #768 to the new workflow file |
It's weird that |
Oh, it's due to two different PRs being merged that conflicted without touching the same files |
push: | ||
branches: | ||
- main | ||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this line should be removed
This is basically ready to land |
Looks like there's also been some updates to the github actions upstream. I'm trying out uprevving |
This merges the book repository into the diplomat repository proper, which should allow for better maintaining the documentation as well as making it more clear which version of diplomat any particular revision of the book is referring to.
Commit history was edited via git-filter-repo & should be maintained by this PR