Code

JS Constructor Attr Support#754

Code

Merged

Manishearth merged 96 commits intorust-diplomat:mainrust-diplomat/diplomat:mainfrom ambiguousname:js-constructor-attrambiguousname/diplomat:js-constructor-attrCopy head branch name to clipboardJan 15, 2025

+2,486-1,294

Commits

Commits on Dec 15, 2024

• Add constructor presence detection

  ambiguousname

  committed
  ec7d1a1

  Copy full SHA for ec7d1a1

• Unifying JS classes under a base template

  ambiguousname

  committed
  45620ca

  Copy full SHA for 45620ca

Commits on Dec 27, 2024

• Replace constructor presence bool with more detailed info

  ambiguousname

  committed
  644143b

  Copy full SHA for 644143b

• Adding constructor special_method definition

  ambiguousname

  committed
  6a5d3aa

  Copy full SHA for 6a5d3aa

• Switch constructor based on symbol detected

  ambiguousname

  committed
  59094fc

  Copy full SHA for 59094fc

• Add TODOs for typescript behavior

  ambiguousname

  committed
  96acd0a

  Copy full SHA for 96acd0a

• Rename functions if constructor is overridden

  ambiguousname

  committed
  fbb2f70

  Copy full SHA for fbb2f70

• Generation

  ambiguousname

  committed
  f0e6128

  Copy full SHA for f0e6128

• Don't generate constructor body in typescript

  ambiguousname

  committed
  b2b2544

  Copy full SHA for b2b2544

• Generation

  ambiguousname

  committed
  899da95

  Copy full SHA for 899da95

• Replace Opaque .new_ with new keyword

  ambiguousname

  committed
  67df960

  Copy full SHA for 67df960

• Add fromFields method to structs

  ambiguousname

  committed
  5c5316d

  Copy full SHA for 5c5316d

• Add conditionals for fromFields

  ambiguousname

  committed
  c2a3762

  Copy full SHA for c2a3762

• Generation

  ambiguousname

  committed
  7ea60d1

  Copy full SHA for 7ea60d1

• Update tests

  ambiguousname

  committed
  824a180

  Copy full SHA for 824a180

• Formatting

  ambiguousname

  committed
  63d6c33

  Copy full SHA for 63d6c33

• Add clarification to FromFields

  ambiguousname

  committed
  2f8da03

  Copy full SHA for 2f8da03

• Update comment

  ambiguousname

  committed
  2bf6a71

  Copy full SHA for 2bf6a71

• Reuse all arguments instead of slicing

  Show description for e5e22bf
  ambiguousname

  committed
  e5e22bf

  Copy full SHA for e5e22bf

• Generation

  ambiguousname

  committed
  ae0ff13

  Copy full SHA for ae0ff13

Commits on Jan 1, 2025

• Use the new FromFields method

  ambiguousname

  committed
  b4251d8

  Copy full SHA for b4251d8

• Started revising conversion to detect when a function is a constructor

  Show description for 9d6ec66
  ambiguousname

  committed
  9d6ec66

  Copy full SHA for 9d6ec66

• Generation

  ambiguousname

  committed
  609b7c6

  Copy full SHA for 609b7c6

Commits on Jan 2, 2025

• Drafting new struct construction setup

  ambiguousname

  committed
  cfebaa0

  Copy full SHA for cfebaa0

• Generation

  ambiguousname

  committed
  a437c37

  Copy full SHA for a437c37

Commits on Jan 4, 2025

• Re-use internalConstructor for out structs

  ambiguousname

  committed
  d8aaabc

  Copy full SHA for d8aaabc

• Update _createFromFFI to use fields constructor correctly

  ambiguousname

  committed
  62b7062

  Copy full SHA for 62b7062

• Generation

  ambiguousname

  committed
  df8df45

  Copy full SHA for df8df45

• Adding a new symbol for accessing an internal constructor

  ambiguousname

  committed
  eaa8812

  Copy full SHA for eaa8812

• Fixing internal/expose constructor usage

  ambiguousname

  committed
  cb3263e

  Copy full SHA for cb3263e

• Update conversion for struct types to use exposeConstructor

  ambiguousname

  committed
  8ce1546

  Copy full SHA for 8ce1546

Commits on Jan 5, 2025

• Adding internalConstructor test for construction

  Show description for 23271d9
  ambiguousname

  committed
  23271d9

  Copy full SHA for 23271d9

• Generation

  ambiguousname

  committed
  02769cd

  Copy full SHA for 02769cd

• Formatting

  ambiguousname

  committed
  a93422a

  Copy full SHA for a93422a

• Clippy

  ambiguousname

  committed
  f08b45d

  Copy full SHA for f08b45d

• Adding FromValue enum function

  ambiguousname

  committed
  2e4181a

  Copy full SHA for 2e4181a

• Generation

  ambiguousname

  committed
  e328ab9

  Copy full SHA for e328ab9

• Whitespacing

  ambiguousname

  committed
  0ccba45

  Copy full SHA for 0ccba45

• Fix whitespacing, remove duplicate methods for Enums

  ambiguousname

  committed
  ea9e693

  Copy full SHA for ea9e693

• Add new test for enum construction

  ambiguousname

  committed
  fd3c831

  Copy full SHA for fd3c831

• Generation

  ambiguousname

  committed
  829e8e4

  Copy full SHA for 829e8e4

• Fixing some test errors

  ambiguousname

  committed
  4ee7bf2

  Copy full SHA for 4ee7bf2

• Add returns to constructor to allow for modifying object returns

  ambiguousname

  committed
  34d0d08

  Copy full SHA for 34d0d08

• Use return for constructors

  ambiguousname

  committed
  78d4a54

  Copy full SHA for 78d4a54

• Generation

  ambiguousname

  committed
  ed75836

  Copy full SHA for ed75836

• Had typescript right the first time around

  ambiguousname

  committed
  1cbbdeb

  Copy full SHA for 1cbbdeb

• Should check if we're NOT nullish for enums

  ambiguousname

  committed
  34196cd

  Copy full SHA for 34196cd

• Generation

  ambiguousname

  committed
  a62d4ef

  Copy full SHA for a62d4ef

• Formatting

  ambiguousname

  committed
  15deb13

  Copy full SHA for 15deb13

• Update terminus generation for structs

  ambiguousname

  committed
  a70e700

  Copy full SHA for a70e700

Commits on Jan 7, 2025

• Remove usage parameter

  ambiguousname

  committed
  aabf117

  Copy full SHA for aabf117

• Generation

  ambiguousname

  committed
  1120ccf

  Copy full SHA for 1120ccf

• Revert to _fromFFI static func

  ambiguousname

  committed
  4369402

  Copy full SHA for 4369402

• Generation

  ambiguousname

  committed
  f54d923

  Copy full SHA for f54d923

• Formatting

  ambiguousname

  committed
  e2a9dd7

  Copy full SHA for e2a9dd7

• Full generation

  ambiguousname

  committed
  762195f

  Copy full SHA for 762195f

• Merge branch 'main' into js-constructor-attr

  ambiguousname

  committed
  91037e8

  Copy full SHA for 91037e8

• Update with new Kotlin gen

  ambiguousname

  committed
  f593b82

  Copy full SHA for f593b82

Commits on Jan 8, 2025

• Update demo_gen JS to match for new constructor calls

  ambiguousname

  committed
  5470bd8

  Copy full SHA for 5470bd8

• Generation

  ambiguousname

  committed
  cda8927

  Copy full SHA for cda8927

• Update external sample function

  ambiguousname

  committed
  f9dbecd

  Copy full SHA for f9dbecd

• Formatting

  ambiguousname

  committed
  cc271bc

  Copy full SHA for cc271bc

• Changed the wrong file for custom gen

  ambiguousname

  committed
  7c9e9db

  Copy full SHA for 7c9e9db

• Add named parameters back to constructor func

  ambiguousname

  committed
  9425134

  Copy full SHA for 9425134

• Generation

  ambiguousname

  committed
  3ae70cf

  Copy full SHA for 3ae70cf

• Remove Dart support for DefaultEnum

  ambiguousname

  committed
  44fa806

  Copy full SHA for 44fa806

• Struct block end whitespacing

  ambiguousname

  committed
  5fa3baf

  Copy full SHA for 5fa3baf

• Clean up struct field whitespacing

  ambiguousname

  committed
  38188a1

  Copy full SHA for 38188a1

• Clean up opaque whitespacing

  ambiguousname

  committed
  9016065

  Copy full SHA for 9016065

• Generation

  ambiguousname

  committed
  cd000d6

  Copy full SHA for cd000d6

• Hide private methods from typescript

  ambiguousname

  committed
  b81a200

  Copy full SHA for b81a200

• Update TODO

  ambiguousname

  committed
  56f61dd

  Copy full SHA for 56f61dd

• Update constructor and #internalConstructor spacing

  ambiguousname

  committed
  8d37d56

  Copy full SHA for 8d37d56

• Generation

  ambiguousname

  committed
  a7a73ee

  Copy full SHA for a7a73ee

• Whitespacing fix

  ambiguousname

  committed
  6daba72

  Copy full SHA for 6daba72

• Generation

  ambiguousname

  committed
  0028555

  Copy full SHA for 0028555

• Formatting

  ambiguousname

  committed
  5912689

  Copy full SHA for 5912689

• Renaming helpers to use camelCase

  ambiguousname

  committed
  a188e86

  Copy full SHA for a188e86

• Generation

  ambiguousname

  committed
  c8e657e

  Copy full SHA for c8e657e

• Last fromFields rename

  ambiguousname

  committed
  62168a1

  Copy full SHA for 62168a1

• Tests update

  ambiguousname

  committed
  5ff4bb2

  Copy full SHA for 5ff4bb2

• Generation

  ambiguousname

  committed
  04983aa

  Copy full SHA for 04983aa

• Merge branch 'main' into js-constructor-attr

  ambiguousname

  committed
  a1e1186

  Copy full SHA for a1e1186

Commits on Jan 10, 2025

• Move constructor() definition to one place

  ambiguousname

  committed
  d5add29

  Copy full SHA for d5add29

• Formatting

  ambiguousname

  committed
  754818b

  Copy full SHA for 754818b

• Show constructor if it's overridden

  ambiguousname

  committed
  8865970

  Copy full SHA for 8865970

• Generation

  ambiguousname

  committed
  b6b82fb

  Copy full SHA for b6b82fb

• Fix logic on generating ctor for structs

  ambiguousname

  committed
  fcda21e

  Copy full SHA for fcda21e

• Generation

  ambiguousname

  committed
  ce2cb37

  Copy full SHA for ce2cb37

• Always return this with #internalConstructor

  ambiguousname

  committed
  0808821

  Copy full SHA for 0808821

• Generation

  ambiguousname

  committed
  4963b43

  Copy full SHA for 4963b43

• Clarifying use of internalConstructor and exposeConstructor

  ambiguousname

  committed
  fae4f8e

  Copy full SHA for fae4f8e

• Generation

  ambiguousname

  committed
  2909ef9

  Copy full SHA for 2909ef9

• Documenting show_default_ctor

  ambiguousname

  committed
  df98f2d

  Copy full SHA for df98f2d

Commits on Jan 15, 2025

• Update tool/templates/js/runtime.mjs

  Manishearth

  authored
  b2967f3

  Copy full SHA for b2967f3

• regen

  Manishearth

  committed
  785fcb2

  Copy full SHA for 785fcb2