Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .mjs tests in feature_tests/js, use only .mts files #750

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Remove .mjs tests in feature_tests/js, use only .mts files #750

merged 3 commits into from
Dec 13, 2024

Conversation

ambiguousname
Copy link
Member

Fixes #737

@ambiguousname
Copy link
Member Author

Also fixes a bug in typescript where optional parameters to a struct are not labelled with ? in their _Obj type.

@Manishearth Manishearth merged commit 1d6942e into rust-diplomat:main Dec 13, 2024
20 checks passed
@Manishearth
Copy link
Contributor

The test files can probably be renamed, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move JS tests all into Typescript
2 participants
@ambiguousname @Manishearth