Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS Functions can accept struct params as JS objects #734

Merged
merged 46 commits into from
Dec 13, 2024
Merged

JS Functions can accept struct params as JS objects #734

merged 46 commits into from
Dec 13, 2024

Conversation

ambiguousname
Copy link
Member

@ambiguousname ambiguousname commented Nov 21, 2024 •
edited
Loading

Fixes #720.

TODO:

  • Add test for nested struct construction
  • Don't think nested structs are actually recognized yet. Need to update struct construction code to fix this.
  • Label parameters correctly in typescript
  • StructTypeName_Obj with recursive structs also need StructTypeName | StructTypeName_Obj labeling in typescript

@ambiguousname ambiguousname added the B-js JS backend label Nov 21, 2024
Manishearth
Manishearth approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I wodner if we should also make this clear in the typescript types or let it be under the hood.

@ambiguousname
Writing test for recursive construction
ccd8b8a
@ambiguousname
Adding tests for both kinds of construction
3930b12
@ambiguousname
Better test names
eef60ee
@ambiguousname
Giving tests more accurate names
e3bbf42
@ambiguousname
Formatting
3651fa8
@ambiguousname
Started on typescript recognizing Struct_Obj types and new import system
73fe37a
@ambiguousname
Start on adding file paths to import info
209abe4
@ambiguousname
Add import usage field
c8133b6
@ambiguousname
Add ImportUsage definitions
e3bd9b1
@ambiguousname
Matching output to given ImportInfo
256b33b
@ambiguousname
Wrong file
05fc87a
@ambiguousname
Defining what makes an import unique for the set
6b1397f
@ambiguousname
Fixing hash set issues
51a7b59
@ambiguousname
Generation
edcf1f5
@ambiguousname
Formatting
12ddcd0
@ambiguousname
_Obj types also now add _Obj to accepted struct field types
60630b8
@ambiguousname
Remove _Obj import in definition file
5fc0a74
@ambiguousname
Simplify parameter/field acceptance for structs
ae1927c
@ambiguousname
Generation
5b13cef
@ambiguousname
New test
62d08c6
@ambiguousname
One more test
a0f9b0a
@ambiguousname
Lowercase o to avoid collisions
c3082a6
@ambiguousname
Generation
9799b32
@ambiguousname
Formatting
1d1613c
@ambiguousname
Copy link
Member Author

ambiguousname commented Dec 5, 2024 •
edited
Loading

All that's left is one test that's returning an error. I think it's something to do with a receiveBuffer being created when the generated WASM doesn't call for one, am investigating.

Edit: Found the cause. Opened #739

@ambiguousname ambiguousname changed the title JS Functions can accept Javascript objects JS Functions can accept struct params as JS objects Dec 5, 2024
@ambiguousname ambiguousname mentioned this pull request Dec 5, 2024
Closed
@ambiguousname
Copy link
Member Author

Need to do some generation in other languages, but this is good to review now.

@ambiguousname ambiguousname marked this pull request as ready for review December 5, 2024 20:59
Manishearth
Manishearth approved these changes Dec 6, 2024
View reviewed changes
tool/src/js/gen.rs Outdated Show resolved Hide resolved
@ambiguousname
Copy link
Member Author

Waiting on #742 to be merged before I update this (so I can revert the CyclicStruct feature tests)

@Manishearth Manishearth merged commit b9aab0c into rust-diplomat:main Dec 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
B-js JS backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JS2 constructors: structs and enums should autoconvert at parameter/struct boundaries
2 participants
@ambiguousname @Manishearth