Demo Gen support for DiplomatOption #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we currently don't pass context when we recursively evaluate parameters, DiplomatOption effectively is ignored for the purposes of demonstration. Especially difficult to resolve since we flatten all struct and opaque construction into one render terminus (making it hard to set up optional support), so this is a workaround for now.
Manishearth
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we currently don't pass context when we recursively evaluate parameters, DiplomatOption effectively is ignored for the purposes of demonstration.
Especially difficult to resolve since we flatten all struct and opaque construction parameters into one render terminus (making it hard to label what belongs where and thus set up optional support), so this is a workaround for now.
Should help with the ICU4X PR for
DiplomatOption<>