Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo Gen Backend Customization #618

Merged
merged 23 commits into from
Aug 6, 2024

Conversation

ambiguousname
Copy link
Member

Includes a host of improvements that make configuring default demo_gen behavior much easier.

Firstly, all rendering has been moved to one file, but it uses search params to select a terminus function to render.

There are also a few customization options with -l that allow for things like disabling the default renderer output and explicit opt-in for demo_gen output.

@ambiguousname ambiguousname added the B-demo_gen Demo_Gen backend label Aug 5, 2024
@ambiguousname ambiguousname linked an issue Aug 5, 2024 that may be closed by this pull request
Copy link
Contributor

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm!!

Copy link
Contributor

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@ambiguousname ambiguousname merged commit e822cba into rust-diplomat:main Aug 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-demo_gen Demo_Gen backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo_Gen: Additional Customization Options
3 participants