Add support for multi-module projects #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functions not public
Merged
Manishearth
reviewed
Jul 23, 2021
| declared_types: custom_types_by_name, | ||
| sub_modules, | ||
| } | ||
| } | ||
| } | ||
|
|
||
| fn extract_imports(base_path: &Path, use_tree: &UseTree, out: &mut Vec<(Path, String)>) { |
There was a problem hiding this comment.
I would only extract tagged imports, other imports should just be ignored IMO.
There was a problem hiding this comment.
Hmm, is there any advantage from the Diplomat side for doing this? We handle unsupported imports by erroring out when one would be needed to resolve a path, so was thinking of only requiring annotations for DSTs to reduce noise.
|
|
||
| use super::{CustomType, Method, ModSymbol, OpaqueStruct, Path, Struct, TypeName}; | ||
|
|
||
| #[derive(Clone, Serialize, Deserialize, Debug)] | ||
| pub struct Module { | ||
| pub name: String, | ||
| pub imports: Vec<(Path, String)>, |
There was a problem hiding this comment.
If we only extract tagged imports, should these just add to the list of declared types?
There was a problem hiding this comment.
We want to support imports of other modules, so we can't assume that the import always is to a type.
Manishearth
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Support wildcard imports(Support wildcard imports when processing modules #31)