Fix failure to generate feature_tests #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah we should rewrite these tests but this lgtm |
QnnOkabayashi
approved these changes
May 26, 2022
| Foo_box_destroy_registry.register(out, out.underlying) | ||
| return out; | ||
| })(); | ||
| wasm.diplomat_free(x_diplomat_ptr, x_diplomat_bytes.length, 1); |
There was a problem hiding this comment.
This is gonna cause errors but we can fix later
| get_bar() { | ||
| const diplomat_out = (() => { | ||
| const out = (() => { | ||
| const out = new Bar(wasm.Foo_get_bar(this.underlying)); |
There was a problem hiding this comment.
Also cursed cause we don't ensure that this isn't dropped
|
Once #12 gets merged we can make another PR to fix these tests again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we weren't testing that feature_tests was appropriately generated in CI, and it was failing since the selftype test was referring to non-opaque structs behind references. It's worth rewriting the test, but I don't want to do that here