JS also supports fallible ctors

rust-diplomat · Jan 15, 2025 · f024d39 · f024d39
1 parent 1023a40
commit f024d39
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 9 deletions.
diff --git a/feature_tests/js/api/ResultOpaque.d.ts b/feature_tests/js/api/ResultOpaque.d.ts
diff --git a/feature_tests/js/api/ResultOpaque.mjs b/feature_tests/js/api/ResultOpaque.mjs
diff --git a/feature_tests/src/result.rs b/feature_tests/src/result.rs
@@ -24,12 +24,12 @@ pub mod ffi {
             Ok(Box::new(ResultOpaque(i)))
         }
 
-        #[diplomat::attr(all(*, supports = fallible_constructors), named_constructor = "failing_foo")]
+        #[diplomat::attr(all(supports = named_constructors, supports = fallible_constructors), named_constructor = "failing_foo")]
         pub fn new_failing_foo() -> Result<Box<ResultOpaque>, ErrorEnum> {
             Err(ErrorEnum::Foo)
         }
 
-        #[diplomat::attr(all(*, supports = fallible_constructors), named_constructor = "failing_bar")]
+        #[diplomat::attr(all(supports = named_constructors, supports = fallible_constructors), named_constructor = "failing_bar")]
         pub fn new_failing_bar() -> Result<Box<ResultOpaque>, ErrorEnum> {
             Err(ErrorEnum::Bar)
         }
@@ -40,7 +40,7 @@ pub mod ffi {
             Err(())
         }
 
-        #[diplomat::attr(all(*, supports = fallible_constructors), named_constructor = "failing_struct")]
+        #[diplomat::attr(all(supports = named_constructors, supports = fallible_constructors), named_constructor = "failing_struct")]
         pub fn new_failing_struct(i: i32) -> Result<Box<ResultOpaque>, ErrorStruct> {
             Err(ErrorStruct { i, j: 12 })
         }

diff --git a/tool/src/js/mod.rs b/tool/src/js/mod.rs
@@ -46,7 +46,7 @@ pub(crate) fn attr_support() -> BackendAttrSupport {
 
     a.constructors = true;
     a.named_constructors = false;
-    a.fallible_constructors = false;
+    a.fallible_constructors = true;
     a.accessors = true;
     a.comparators = false;
     a.stringifiers = false; // TODO