-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using asm and global_asm from core::arch module. #157
Conversation
Hit another issue when trying to compile for the currently nightly:
(and similar across that file) I've just started diving into gba/asm/arm stuff for rust and only vaguely understand the above problem. Lemme know if there is a quick fix I can add to this PR, or I can keep going down that rabbit hole. |
That's an error regarding how instruction_set and asm interact. it's not fixable within the crate, it's a rustc problem. |
Dang. With this commit I was able to build the hello world example on |
For now I think you should just comment out all the offending functions, and i think they're all called as part of a match expression elsewhere so fix up that too. Basically they're intended to provide semi-atomic copying for large values, and missing out on the larger variations just cuts how big of a value you can use. So, they're in some sense "non-essential". I know the person that helped implement instruction_set and they might be able to do the PR to rustc to fix this, until then we'll just have some commented out code. |
I added some Seems to compile and build with the current nightly now! |
The way it is now, every possible code path of the function is a panic it looks like. Since it will panic no matter what, we should just comment out the whole function. |
Fair. I could move the panic to the top of the function? Granted this might not be a concern in this setting, but I hate just disappearing functions from a lib/api without good errors for users of it. In any case, I'll comment out the whole thing unless you get back and prefer the panic route. |
It's a little painful for a function to go away, I agree, but it's still better than having a panic lurking a potentially rare code path. |
Good point, better to explode at build time than at run time. fn removed and update the transfer fn. |
Just to follow up, I think I have all your suggestions incorporated and this compiles against nightly. No rust, just wanted to make sure you are not waiting on me. |
no no no, all my fault, i had meant to get to this earlier today in fact but got caught up in things. |
Update to pull
asm
andglobal_asm
fromcore::arch
now that they live there.Fixes #156