Rollup! #10
Rollup! #10
Conversation
|
r+ for the |
| @@ -99,5 +115,5 @@ pub fn handle_dump(panic_info: &PanicInfo) -> Result<String, FailError> { | |||
| } | |||
|
|
|||
| let report = Report::new(Method::Panic, expl); | |||
| return report.persist(); | |||
| report.persist() | |||
There was a problem hiding this comment.
I am a fan of explicit return statements but I think I'm in the minority there in the Rust community 😜
There was a problem hiding this comment.
Who cares what the rust community thinks – clippy doesn't like it :D
There was a problem hiding this comment.
Al̶l̛ ̨hai̷l҉ th̵è įǹfa͝l҉lib̢le cĺi̴p͟p̵y̸
|
@killercup as a side note: I don't usually tend to bump versions in a PR, but instead wait until after merge. Usually so it can be labeled & tagged in a separate commit / shows up in the commit log as standalone. Nothing to block this on though. |
|
@yoshuawuyts ah no, that's fine, I just saw your comment in #6 about the version bump and went ahead. Let me remove that commit here. We should probably go over the docs before a release anyway |
chore(config): migrate renovate config
Wow, there's a lot of stuff going on in this repo! This is a rollup of #6 and #9 -- and I'm pretty sure also of #8 of which #9 is pretty much a superset.
So, to summarize:
Path/PathBufinstead ofStringin a few places…and it finally it bumps the version to 0.3 because, even though
print_msgnow accepts strictly more inputs (you can still pass in aStringbut now also give it aPathorPathBufof&str), the output type ofhandle_dumpchanged :(