Adds a new constructor and init functions for custom env vars. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three new methods/functions that are like existing ones, but allow you to specify the name of the environment variable to parse: * `Logger::from_env`, which is like `Logger::new`. * `init_from_env`, which is like `init`. * `try_init_from_env`, which is like `try_init`. Refs #23 Refs rust-lang/log#83
|
Thanks again @jimmycuadra! I think this looks good. There probably isn't a whole lot of value testing the environment vars, since they just hand off to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three new methods/functions that are like existing ones, but allow you to specify the name of the environment variable to parse:
Logger::from_env, which is likeLogger::new.init_from_env, which is likeinit.try_init_from_env, which is liketry_init.I also changed the docs for the init functions slightly to make it clearer what the difference is between them all when reading the docs for the crate root.
I haven't added any new tests, but I'd be happy to if desired. Let me know if there is a preferred way of working with environment variables to keep tests deterministic.
Refs #23
Refs rust-lang/log#83