Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check out feedback from "Adventures in logging" post #21

Closed
sebasmagri opened this issue Aug 31, 2017 · 2 comments
Closed

Check out feedback from "Adventures in logging" post #21

sebasmagri opened this issue Aug 31, 2017 · 2 comments

Comments

@sebasmagri
Copy link
Collaborator

https://unhandledexpression.com/2017/08/23/adventures-in-logging/
@quadrupleslap
Copy link
Contributor

The main complaint in that post was that every call allocates a string, but it looks like env_logger tries to reuse buffers now (haven't actually looked closely at it though), so it looks like this has been resolved.

@KodrAus
Copy link
Collaborator

KodrAus commented Jan 21, 2018

I'm happy to close this now too 👍

@KodrAus KodrAus closed this as completed Jan 21, 2018
epage added a commit to epage/env_logger that referenced this issue Jul 26, 2024
@epage
Merge pull request rust-cli#21 from jalil-salame/patch-1
045de93 
Fix typos in CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sebasmagri @quadrupleslap @KodrAus