-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update libsecp, remove endomorphism feature flag and release 0.20.0 #257
Conversation
83663db
to
833b176
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like an important and trivial bugfix which may get merged before this release: #266 |
Can you also remove the endianess checks? they aren't needed anymore bitcoin-core/secp256k1#787 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
I tested rm -rf /depend/secp256k1
and ./vendor-libsecp.sh depend 0_4_0 master
to make sure the results match,
585d43d
to
8511ec0
Compare
8511ec0
to
c4d2fef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK c4d2fef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK, ran the vendoring script on my machine and it produced the same result
No description provided.