fixes for last couple months of CI changes #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cargo now complains about #[cfg] attributes that don't match cargo features, unless you explicitly whitelist them. This is very useful for catching typos. Whitelist the ones we use, and set the lint from "warn" to "deny".
Appears to have been an accidental addition during iteration on rust-bitcoin#117.
tcharding
reviewed
Jul 5, 2024
| #[inline] | ||
| fn size_hint(&self) -> (usize, Option<usize>) { self.iter.size_hint() } | ||
| } | ||
|
|
There was a problem hiding this comment.
Interesting, that is twice this week that code that I have worked on includes types that are not constructable. Seems this should be caught by the linter.
There was a problem hiding this comment.
It's a recent addition (only last couple weeks) to the rustc "dead code" lint. It's actually pretty clever because this is a publicly exported type -- there's just no publicly-exported function that returns it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy, public-api and cargo.