This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Enable edition 2018 #136
Merged
Enable edition 2018 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
edition-2018
branch
from
2128495 to
5c48b58
Compare
tcharding
force-pushed
the
edition-2018
branch
2 times, most recently
from
4dc9f77 to
d0dab4c
Compare
20 tasks
tcharding
force-pushed
the
edition-2018
branch
2 times, most recently
from
948e3cb to
c2a5d1c
Compare
|
Now includes version bump to |
|
Requires GitHub configuration change please @apoelstra to remove the Rust 1.29 CI job. |
Remove two instances of trailing whitespace character.
It seems we have consensus on bumping the MSRV to 1.41.1, update CI job and the README to reflect this.
Add `edition = "2018"` to the minifest file. In order to get the codebase to build cleanly do: - Remove usage of `use Hash as HashTrait`, instead use `impl crate::Hash for Hash` and `use Hash as _`. - Same for HashEngine (remove EngineTrait). - Add `crate::` to import statements and group same level (only did this for crate imports, the rest can wait for rustfmt :) - Make test imports uniform, elect to _not_ use `super::*` because it seems cleaner, we are always importing the module we are testing and the same set of traits in each `test` module. Can change if requested.
We just bumped the MSRV, this is a major change but since we are pre 1.0 we just have to bump the minor version number. Bump version from current `0.10.0` to `0.11.0`.
|
No changes in force push, rebase only. |
apoelstra
approved these changes
May 3, 2022
|
Tagged and published the release. I don't know how this slipped between the cracks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the MSRV to Rustn 1.41.1 and enable edition 2018.
Should not be merged without rust-bitcoin organization-wide planning on how to go about this upgrade.
Discussion: rust-bitcoin/rust-bitcoin#510 (comment)
This one is a bit more involved than the same PRs for rust-bech32 or rust-bitcoinconcensus.
The commit message of patch 3:
Thanks