-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the nom-language crate #1792
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1792 +/- ##
==========================================
- Coverage 62.01% 61.43% -0.59%
==========================================
Files 23 25 +2
Lines 2980 3127 +147
==========================================
+ Hits 1848 1921 +73
- Misses 1132 1206 +74 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #1792 will not alter performanceComparing Summary
|
* Initial prototype * Update docs Remove unused code * More doc updates * Add feature flags for Vec * Add basic tests * Fix formatting * Add precedence to choosing_a_combinator.md * Fix typo * Minor refractoring * Update docs * Change parameter order * Add alloc feature to the entire precedence module The parser really cant work without it and the helpers dont make much sense without the parser. * Use fail parser to express "no operators of this type" * Document evaluation order * Better documentation for parameters * Fix precedence in documentation * Fix doc formatting * Fix typos * Use map_res when parsing integers * Example test for expressions with function calls and AST generation * Typo * Make evaluation a bit easier to read * Update expression_ast * Update expression_ast doc * Implement ternary operator in expression_ast * Shorten ast nodes * Implement some tests for parser failures * Update feature flags for docs * Properly append errors * Properly bubble up non Error errors * Split operators into 3 distinct types to help with exhaustiveness checks. --------- Co-authored-by: Geoffroy Couprie <[email protected]>
Co-authored-by: Geoffroy Couprie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates language focused parts of nom in the nom-language crate, to give them different lifecycle and better allow them to evolve