-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add start frame and frames option to video comparison #45
Conversation
Maybe rename |
Should |
Simple |
Well, it's ready to review then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a logic error hiding there w.r.t. end_frame
. And forgive me for being strict, but I don't like calc_score
becoming so complex if we can avoid it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it a bit and everything works fine. One nitpick though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@shssoichiro I forgot to squash this when merging. Not sure if it bothers you, if it does we can squash it manually on main |
No biggie. I'd rather keep it unsquashed than deal with rewriting history in main. Thanks! |
Adds two new arguments:
-s (--start)
sets the frame to start the comparison process at. 0 is the first frame.--skip-frames
sets the amount of frames to skip.--frames
The amount of frames (in total) to compare.Also adjusts the progress bar to only count the amount of frames that get computed.
Todo
--increment
arg valuesCloses #19