Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make clippy happier #57

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Make clippy happier #57

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6c0bcc6
Remove Iterator::fold impl for Children
CAD97 Apr 26, 2020
ba1df75
Remove redundant lifetime annotation
CAD97 Apr 26, 2020
5228453
Remove identity calls to Into::into
CAD97 Apr 26, 2020
19a2c1f
Remove use of `unwrap_or` followed by a function call
CAD97 Apr 26, 2020
1441e73
Remove unnecessary reference of comparison operator
CAD97 Apr 26, 2020
be56ab8
Allow clippy::unit_arg
CAD97 Apr 26, 2020
3f3aa59
Use next instead of nth in s_expr example
CAD97 Apr 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/syntax_text.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ impl SyntaxText {

pub fn slice<R: private::SyntaxTextRange>(&self, range: R) -> SyntaxText {
let start = range.start().unwrap_or_default();
let end = range.end().unwrap_or(self.len());
let end = range.end().unwrap_or_else(|| self.len());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false positive imo

assert!(start <= end);
let len = end - start;
let start = self.range.start() + start;
Expand Down