Runtime Observable Settings #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm traveling right now so I probably won't get a chance to review this closely for a week or so. I'm still not sure how I feel on the naming, but will probably merge it with what you have and change it before I put out a release with it. Speaking of the next release, I already have a 1.2 branch with some other pending updates. Do you think you can rebase against that branch? If not, I can do it when I'm back. I'm guessing the only major change needed will be the gradle files because I converted the old buildsrc code to use script plugins. |
|
To fix the CI failure, run the |
psuzn
force-pushed
the
sp/runtime-observable-settings
branch
from
109671d to
8da35e3
Compare
|
@russhwolf, any update on this? |
russhwolf
reviewed
Mar 23, 2024
multiplatform-settings-runtime-observable/src/commonMain/kotlin/Converter.kt
Outdated
Show resolved
Hide resolved
...rm-settings-runtime-observable/src/commonTest/kotlin/RuntimeObservableSettingsWrapperTest.kt
Outdated
Show resolved
Hide resolved
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the wrapper around the normal setting (#155 ) to make it runtime observable.
@russhwolf I have named it
runtime-observablebut we can rename it if there is a better name.I also have added the
checkObservableflag on the converter extension function, so one can just use theno-arginitializer and use the converter to make it observable. In some platforms, the instance returned byno-argis already observable; in that case, the converter doesn't add any wrapper.