Skip to content

Commit

Permalink
Use 'RUNDIR' from make for rhel/ovn-controller.service
Browse files Browse the repository at this point in the history
Perviously it was using the platform's runtime directory which can be
different from the runtime directory of ovsdb-server started by the
openvswitch service

Signed-off-by: Babu Shanmugam <[email protected]>
Acked-by: Flavio Leitner <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
  • Loading branch information
anbu-enovance authored and russellb committed Mar 7, 2016
1 parent 6019cb6 commit 8520dee
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions rhel/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ openvswitch-kmod-rhel6.spec
openvswitch-kmod-fedora.spec
openvswitch.spec
openvswitch-fedora.spec
usr_lib_systemd_system_ovn-controller.service
3 changes: 3 additions & 0 deletions rhel/automake.mk
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ EXTRA_DIST += \
rhel/usr_lib_systemd_system_openvswitch.service \
rhel/usr_lib_systemd_system_openvswitch-nonetwork.service \
rhel/usr_lib_systemd_system_ovn-controller.service \
rhel/usr_lib_systemd_system_ovn-controller.service.in \
rhel/usr_lib_systemd_system_ovn-controller-vtep.service \
rhel/usr_lib_systemd_system_ovn-northd.service

Expand All @@ -51,6 +52,8 @@ $(srcdir)/rhel/openvswitch.spec: rhel/openvswitch.spec.in $(top_builddir)/config
$(srcdir)/rhel/openvswitch-fedora.spec: rhel/openvswitch-fedora.spec.in $(top_builddir)/config.status
$(update_rhel_spec)

$(srcdir)/rhel/usr_lib_systemd_system_ovn-controller.service: rhel/usr_lib_systemd_system_ovn-controller.service.in $(top_builddir)/config.status

RPMBUILD_TOP := $(abs_top_builddir)/rpm/rpmbuild

# Build user-space RPMs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ After=openvswitch.service

[Service]
Type=simple
Environment=OVS_RUNDIR=%t/openvswitch
Environment=OVS_DB=unix:%t/openvswitch/db.sock
Environment=OVS_RUNDIR=@RUNDIR@
Environment=OVS_DB=unix:@RUNDIR@/db.sock
ExecStart=/usr/bin/ovn-controller -vconsole:emer -vsyslog:err -vfile:info \
--log-file=/var/log/openvswitch/ovn-controller.log \
--no-chdir --pidfile=${OVS_RUNDIR}/ovn-controller.pid ${OVS_DB}

0 comments on commit 8520dee

Please sign in to comment.