Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add framework and Carthage support #57

Closed
wants to merge 4 commits into from

Conversation

hankbao
Copy link

@hankbao hankbao commented Jun 18, 2015

No description provided.

@ruslanskorb
Copy link
Owner

screen shot 2015-06-18 at 9 54 59 pm

@pronebird
Copy link
Contributor

I suppose this import will only work on framework, but hey what's wrong with good old include we had before?

@hankbao
Copy link
Author

hankbao commented Jun 22, 2015

Oops... my bad. I've fixed that import statement and also updated the missing visibility setting of framework headers in f97786b.

@hankbao
Copy link
Author

hankbao commented Jun 22, 2015

It seems there are still some building issues on Travis CI with the newly added protected header importing statement in the framework umbrella header. However, that protected header should be put there if we need to expose it to the framework users as I understand. Or should I mark it as the private header of the framework?

@hankbao
Copy link
Author

hankbao commented Jun 23, 2015

As Travis CI is happy with recent commits now, hopefully this pr could be merged.

@abbysingh
Copy link

Hey is carthage support available in master now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants