Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose cropImage method #55

Merged
merged 5 commits into from
Jun 11, 2015
Merged

Expose cropImage method #55

merged 5 commits into from
Jun 11, 2015

Conversation

dbergman
Copy link
Contributor

@dbergman dbergman commented Jun 9, 2015

I want to use my own UI design and use the cropping method provided in this source. By exposing the cropImage method I can use my own button and add cropImage as the target.

@ryang1428
Copy link

+1

@ruslanskorb
Copy link
Owner

I would like to see the following changes:

[1] Add the category RSKImageCropViewControllerProtected.
[2] Move the method cropImage to the category RSKImageCropViewControllerProtected.
[3] Update the comment for the method cropImage (Asynchronously crops the original image in accordance with the current settings).
[4] Extract and expose the method cancelCrop and the method reset: (=> RSKImageCropViewControllerProtected).
[5] Add comments for the method cancelCrop and the method reset:.

@dbergman
Copy link
Contributor Author

@ruslanskorb I added RSKImageCropViewControllerProtected.

ruslanskorb added a commit that referenced this pull request Jun 11, 2015
Extracts and exposes some internal methods for subclasses.
@ruslanskorb ruslanskorb merged commit 8d03fcc into ruslanskorb:master Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants