Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't import RSKImageScrollView #94

Closed
ale0xb opened this issue Feb 2, 2016 · 0 comments
Closed

Can't import RSKImageScrollView #94

ale0xb opened this issue Feb 2, 2016 · 0 comments

Comments

@ale0xb
Copy link

ale0xb commented Feb 2, 2016

With last 1.5.0 update my compilation fails when installing the library using Cocoapods, complaining it can't find the file.

I am using RSKimageScrollView (amongst others) in my code, but noticed in the last update only a few headers were exposed:

s.public_header_files = [ 'RSKImageCropper/RSKImageCropper.h', 'RSKImageCropper/RSKImageCropViewController.h', 'RSKImageCropper/RSKImageCropViewController+Protected.h' ]

I wonder if this was intended?
My assumption is it's a mistake as it breaks backwards compatibility for some use cases of the library.

Have a PR ready that fixes the issue in case I'm right. #93
ruslanskorb added a commit that referenced this issue Feb 3, 2016
@ruslanskorb
[podspec] Replace 'public_header_files' by 'module_map'.
815d091 
Fixes #90.
Fixes #94.
Close #93.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ale0xb