-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent user from cropping a photo with edges outside of the image boundary #234
Comments
Hi @matthewjsloane, Thank you for the question! You probably need the |
Hi thanks for the quick response. I noticed that property but it seems like it only prevents the mask from exceeding the image boundary after the user stops dragging the mask. If the user taps the submit button while the mask is still being dragged, it's possible for there to be empty space still as far as I can tell -- let me know if that's not the case. |
If I understood you correctly, you are looking for a way to configure the At the moment RSKImageCropper has no such functionality. But it is possible to add new properties viewController.avoidEmptySpaceAroundImage = YES;
viewController.bounces = NO;
viewController.bouncesZoom = NO; If you get the chance to do this and open the PR, I'll be happy to add these changes to RSKImageCropper. |
not yet? |
I did like this. |
Hi all, I noticed that if you use the image cropping tool and have one or more edges that extend past the image boundary, it is possible for the cropped image that is returned to be non-square (unequal width and height). I am using the circular image mask.
In the Contacts app, it prevents you from pressing the submit button while your cropping mask extends past the image boundary.
In my own app, I plan to work around this by preventing submission while the cropped image is not square, or resizing/recentering the image based on the smaller width/height if the sides are unequal.
I was wondering if there were any plans to do any of the following:
Thanks in advance for your help, and if this functionality already exists and I'm just missing something, please let me know.
The text was updated successfully, but these errors were encountered: