I set applyMaskToCroppedImage = YES,but the returned image have margins and their alpha is 0.

[shenguanjiejie]

Then I call UIImageJPEGRepresentation(image,1); the margins will turn to whiteColor. like that

[ruslanskorb]

Sorry, but I didn't understand your problem. Please provide more information.

[shenguanjiejie]

😂 Sorry~
RSKImageCropViewController *imageCropVC = [[RSKImageCropViewController alloc] initWithImage:image];
imageCropVC.applyMaskToCroppedImage = YES;

Then I call UIImageJPEGRepresentation(croppedImage,1);

result:

[ruslanskorb]

Try to set avoidEmptySpaceAroundImage to true.

[shenguanjiejie]

Not work..

[ruslanskorb]

Can you, please, provide your implementation of RSKImageCropViewControllerDataSource methods and the image you trying to crop?

[shenguanjiejie]

PS: self.shouldClipToCircle is false

#imageSize is clipSize🤭

#pragma mark - RSKImageCropViewControllerDelegate
- (CGRect)imageCropViewControllerCustomMaskRect:(RSKImageCropViewController *)controller{
    return [self getRect];
}

- (UIBezierPath *)imageCropViewControllerCustomMaskPath:(RSKImageCropViewController *)controller{
    CGRect rect = [self getRect];
    
    if (self.shouldClipToCircle) {
        return [UIBezierPath bezierPathWithArcCenter:CGRectGetCenter(rect) radius:rect.size.width / 2.0 startAngle:0 endAngle:2*M_PI clockwise:YES];
    }
    
    return [UIBezierPath bezierPathWithRect:rect];
}

- (void)imageCropViewControllerDidCancelCrop:(RSKImageCropViewController *)controller{
    [self.navigationController popViewControllerAnimated:YES];
}

-(void)imageCropViewController:(RSKImageCropViewController *)controller willCropImage:(UIImage *)originalImage{
//        int controllerCount = (int)self.navigationController.viewControllers.count;
//        [self.navigationController popToViewController:self.navigationController.viewControllers[controllerCount - 3] animated:YES];
}

- (void)imageCropViewController:(RSKImageCropViewController *)controller didCropImage:(UIImage *)croppedImage usingCropRect:(CGRect)cropRect{
    if (_imagesCompletion) {
        _imagesCompletion([NSArray arrayWithObject:croppedImage]);
    }
    [self.navigationController setNavigationBarHidden:NO animated:NO];
    int controllerCount = (int)self.navigationController.viewControllers.count;
    [self.navigationController popToViewController:self.navigationController.viewControllers[controllerCount - 3] animated:YES];
    
}

#pragma mark 辅助方法

- (CGRect)getRect{
    //
    if (self.imageSize.width == 0 || self.imageSize.height == 0) {
        self.imageSize = CGSizeMake(kScreenWidth, kScreenWidth);
    }
    
    CGFloat scale = MIN(kScreenWidth / self.imageSize.width, kScreenHeight / self.imageSize.height);
    CGSize scaleSize = CGSizeMake(scale * self.imageSize.width, scale * self.imageSize.height);
    CGRect rect = CGRectMake(self.view.centerX - scaleSize.width / 2.0, self.view.centerY - scaleSize.height / 2.0, scaleSize.width, scaleSize.height);
    return rect;
}

[ruslanskorb]

@shenguanjiejie Please provide values for getRect method.

[shenguanjiejie]

[ruslanskorb]

I mean kScreenWidth, kScreenWidth, self.imageSize.width, self.view.centerX , etc.

[shenguanjiejie]

kScreenWidth = [UIScreen mainScreen].bounds.size.width;
kScreenHeight = [UIScreen mainScreen].bounds.size.height;

[ruslanskorb]

I just checked the code and the image you provided and I can say that everything should work as you need if you set the value of avoidEmptySpaceAroundImage to YES.

[shenguanjiejie]

Did you zoom the image? Have a try.

[ruslanskorb]

Yes, I did. Everything works properly.

[shenguanjiejie]

Sorry about my bad English... You may not understand me. Here is my question with a demo.
https://github.com/shenguanjiejie/RJImagePicker

[ruslanskorb]

What problem do you see in these images?

[shenguanjiejie]

😭😭😭 their

You can try applyMaskToCroppedImage = NO, will no white margins.

[ruslanskorb]

@shenguanjiejie Fixed in develop branch. Please check if it works for you.

[shenguanjiejie]

Perfect! Thanks😀

[ruslanskorb]

Eventually, it is fixed in 1.6.4 🎉
Thanks for reporting!