Skip to content

Commit

Permalink
[Podspec + Sources + Project Settings] Fix redefinition of module `RS…
Browse files Browse the repository at this point in the history
…KImageCropper`.

Xcode 8.3 - Apple LLVM Compiler - Known Issues

When building a framework that has module maps in both the source and the install directories that define the same module, the compiler will show a redefinition message. (28638816)
Workaround: Rename the module map file in the source directory to a non-default name (the default name is module.modulemap or module.map), and set the Module Map File build setting to the renamed module map.

https://developer.apple.com/library/content/releasenotes/DeveloperTools/RN-Xcode/Chapters/Introduction.html

Close #139, fixes #141.
ruslanskorb committed Mar 28, 2017

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent 17ce712 commit 7d5ea88
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion RSKImageCropper.podspec
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ Pod::Spec.new do |s|
s.authors = { 'Ruslan Skorb' => '[email protected]' }
s.source = { :git => 'https://github.com/ruslanskorb/RSKImageCropper.git', :tag => s.version.to_s }
s.platform = :ios, '6.0'
s.module_map = 'RSKImageCropper/module.modulemap'
s.module_map = 'RSKImageCropper/RSKImageCropper.modulemap'
s.source_files = 'RSKImageCropper/*.{h,m}'
s.resources = 'RSKImageCropper/RSKImageCropperStrings.bundle'
s.frameworks = 'QuartzCore', 'UIKit'
2 changes: 2 additions & 0 deletions RSKImageCropper.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
@@ -311,6 +311,7 @@
INFOPLIST_FILE = Framework/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
MODULEMAP_FILE = "$(SRCROOT)/RSKImageCropper/RSKImageCropper.modulemap";
PRODUCT_BUNDLE_IDENTIFIER = "com.ruslanskorb.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = RSKImageCropper;
SKIP_INSTALL = YES;
@@ -328,6 +329,7 @@
INFOPLIST_FILE = Framework/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
MODULEMAP_FILE = "$(SRCROOT)/RSKImageCropper/RSKImageCropper.modulemap";
PRODUCT_BUNDLE_IDENTIFIER = "com.ruslanskorb.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = RSKImageCropper;
SKIP_INSTALL = YES;
File renamed without changes.

0 comments on commit 7d5ea88

Please sign in to comment.