Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default image view frames taking into account screen scale #111

Conversation

viktorasl
Copy link
Contributor

Hardcoded image frames didn't take into account screen scale and was tied to 2x scale. 1x was majorly cropped and 3x was slightly cropped:
screen shot 2016-06-29 at 11 20 38screen shot 2016-06-29 at 11 20 05

Fix rounds values in specified (screen scale) base:
screen shot 2016-06-29 at 11 21 12screen shot 2016-06-29 at 11 21 36

@ruslanskorb ruslanskorb added this to the 1.5.2 milestone Jun 29, 2016
@ruslanskorb
Copy link
Owner

Thanks!

@ruslanskorb ruslanskorb merged commit f258cd3 into ruslanskorb:master Jun 29, 2016
@viktorasl viktorasl deleted the feature/frames-for-different-screen-scales branch August 26, 2016 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants