Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json: Add .load_file and .load_file! #2913

Merged
merged 1 commit into from
Nov 29, 2024
Merged

json: Add .load_file and .load_file! #2913

merged 1 commit into from
Nov 29, 2024

Conversation

@ohai
Copy link
Member

ohai commented Nov 17, 2024

PRありがとうございます。リンク先が切れていたりしています。 8db6906 が意図したものでしょうか?

@tk0miya
Copy link
Contributor Author

tk0miya commented Nov 18, 2024

ありがとうございます。おっしゃるとおりです。 @ohai

こちらの修正を取り込んで PR をアップデートするのが良いでしょうか。それとも ohai さんが取り込む際に修正していただくのが良いでしょうか。 8db6906 のコミットをどうするとよいのかがわからなかったのでお伺いさせてください。

@ohai
Copy link
Member

ohai commented Nov 29, 2024

それでは私のほうで取り込みます。

@ohai ohai merged commit 6793fc6 into rurema:master Nov 29, 2024
9 checks passed
@tk0miya tk0miya deleted the patch-1 branch November 29, 2024 14:10
@tk0miya
Copy link
Contributor Author

tk0miya commented Nov 29, 2024

ありがとうございました!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants