Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constantinople #267

Merged
merged 11 commits into from
Oct 31, 2018
Merged

Constantinople #267

merged 11 commits into from
Oct 31, 2018

Conversation

dwightguth
Copy link
Collaborator

EXTCODEHASH hasn't been fully tested yet because those tests haven't been merged upstream yet, but I will make a followup PR updating the tests submodule and fixing any bugs when it does. The rest have been fully tested and seem to pass, with the exception of two tests that expend more memory than we have on the machine, and two tests that seem to have incorrectly filled result information (which I have filed as a bug on the test repo)

@dwightguth dwightguth requested a review from ehildenb October 11, 2018 15:09
@dwightguth dwightguth force-pushed the constantinople branch 2 times, most recently from a04b51e to 89b8d82 Compare October 12, 2018 18:02
@dwightguth
Copy link
Collaborator Author

@daejunpark I need your help figuring out how to update the specifications so that they will be correct for constantinople.

@dwightguth dwightguth mentioned this pull request Oct 18, 2018
Merged
@dwightguth dwightguth force-pushed the constantinople branch 3 times, most recently from a4b066d to ecbe1d6 Compare October 30, 2018 20:17
@dwightguth dwightguth mentioned this pull request Oct 30, 2018
Merged
ehildenb
ehildenb requested changes Oct 31, 2018
View reviewed changes
Copy link
Member

@ehildenb ehildenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, thanks for the clean commit history.

A couple minor changes, and then I want to review Rsstore one more time on the cleaned up version.

evm.md Outdated Show resolved Hide resolved
data.md Outdated Show resolved Hide resolved
evm.md Show resolved Hide resolved
data.md Outdated Show resolved Hide resolved
@ehildenb
Copy link
Member

Jenkins: test mantis

@ehildenb
Copy link
Member

Jenkins: test this please

@ehildenb
Copy link
Member

Looks good, not sure why tests are failing.

@dwightguth
Copy link
Collaborator Author

Jenkins: test this please

@dwightguth
Copy link
Collaborator Author

Jenkins: test mantis

@dwightguth
Copy link
Collaborator Author

Jenkins: test mantis

1 similar comment
@dwightguth
Copy link
Collaborator Author

Jenkins: test mantis

@dwightguth
Copy link
Collaborator Author

For context, the mantis build failed because of a bug in an updated package on rvwork2 and the standalone build failed because of an intermittent bug involving serialization that we may need to investigate further at some point, but I fixed the former and the latter doesn't have anything to do with this PR, so I just reran everything. It's gotten past the points where it crashed before, so I think it's going to succeed now. I will merge when the tests pass.

@dwightguth dwightguth merged commit 9d39dcd into master Oct 31, 2018
@dwightguth dwightguth deleted the constantinople branch October 31, 2018 16:43
@dwightguth dwightguth mentioned this pull request Oct 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehildenb ehildenb ehildenb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwightguth @ehildenb