Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Refactored configuration_variables.py and logger.py #167

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Fix: Refactored configuration_variables.py and logger.py #167

merged 4 commits into from
Dec 12, 2024

Conversation

jfrverdasca
Copy link
Contributor

What this PR change:

  • Remove unused variables and refactor configuration_variables.py to Django settings
  • Converted logger.py code to Django logging configuration

Reviewers:

Issues:

Print screens showing the changes:

NA

JdFSilva
JdFSilva approved these changes Dec 10, 2024
View reviewed changes
labs/config/settings.py Outdated Show resolved Hide resolved
@jfrverdasca jfrverdasca merged commit e87fa7d into main Dec 12, 2024
1 check passed
@jfrverdasca jfrverdasca deleted the jv/166/configuration_variables branch December 12, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JdFSilva JdFSilva JdFSilva approved these changes

@kenvontucky kenvontucky kenvontucky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfrverdasca @kenvontucky @JdFSilva