Apply "Strategy" like pattern to Vectorizers, Embedders and LLM Requesters #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- makefile updated with Django related commands - allowed host fix
* Added ollama to docker compose * Changed code to use local embedder model (provisional) * Some Todos must be done yet
* First working version * Makefile build added to compose up
* embeddings.py full refactor (Now in labs/embeddings/base) * added new embeddings method in all code where old version was used * tests correction
* Readme now have steps to run OpenAI or Local LLM model * Fix typo in embeddings word
…om-config-model # Conflicts: # config/configuration_variables.py # config/models/config.py # config/settings.py # labs/database/embeddings.py # labs/embeddings/vectorizers/chunk_vectorizer.py # labs/embeddings/vectorizers/python_vectorizer.py # labs/llm.py # labs/tasks/llm.py # tests/conftest.py # tests/database/test_embeddings.py
# Conflicts: # config/configuration_variables.py # config/models/config.py # config/settings.py # labs/database/embeddings.py
…om-config-model # Conflicts: # labs/config/settings.py # labs/config/urls.py # labs/core/migrations/0001_initial.py # labs/core/models.py
# Conflicts: # labs/config/configuration_variables.py # labs/core/migrations/0001_initial.py # labs/embeddings/openai.py # labs/embeddings/vectorizers/chunk_vectorizer.py # labs/llm.py # labs/tasks/llm.py # labs/tests/conftest.py # labs/tests/database/test_embeddings.py # labs/tests/test_local_llm.py # poetry.lock # pyproject.toml
* Added model VectorizerModel * Added VectorizerModel admin * Added VectorizerModel fixtures * Vectorizers now implement Strategy pattern
# Conflicts: # labs/core/admin.py # labs/core/migrations/0001_initial.py # labs/core/models.py # labs/embeddings/embedder.py # labs/embeddings/openai.py # labs/embeddings/vectorizers/chunk_vectorizer.py # labs/litellm_service/llm_requester.py # labs/litellm_service/ollama.py # labs/litellm_service/openai.py # labs/llm.py # labs/tasks/llm.py # labs/tests/conftest.py # labs/tests/test_llm.py
JdFSilva
approved these changes
Nov 21, 2024
* ChunckVectorizer now recieves embedder in init * sample.ipynb bug fix
kenvontucky
reviewed
Nov 21, 2024
kenvontucky
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR change:
Reviewers:
Issues:
Print screens showing the changes:
NA