Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

132/llama3.2+nomic #138

Merged
merged 13 commits into from
Nov 6, 2024
Merged

132/llama3.2+nomic #138

merged 13 commits into from
Nov 6, 2024

Conversation

jfrverdasca
Copy link
Contributor

@jfrverdasca jfrverdasca commented Nov 5, 2024 •
edited
Loading

What this PR change:

  • Add ollama local embeddings support for fast testing
  • Fix docker compose and docker file issues
  • Fix tests to accommodate changes when refactoring embeddings
  • Fix makefile instructions and help
  • Add makefile instruction do pull ollama models

Reviewers:

Issues:

Print screens showing the changes:

NA

@jfrverdasca
Add local embedder model
6f40858 
* Added ollama to docker compose
* Changed code to use local embedder model (provisional)
* Some Todos must be done yet
@jfrverdasca
Add makefile ollama pull command and compose volume
148cac5
@jfrverdasca
Fix local llm run, docker and other little fixes
a8f1d0e 
* First working version
* Makefile build added to compose up
@jfrverdasca
Add local ollama embedder
dd0bdb6 
* embeddings.py full refactor (Now in labs/embeddings/base)
* added new embeddings method in all code where old version was used
* tests correction
@jfrverdasca
Fix merge differences due to embeddings refactor
4f2849c
@jfrverdasca jfrverdasca self-assigned this Nov 5, 2024
kenvontucky
kenvontucky requested changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@kenvontucky kenvontucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment in Readme showcasing how we can set this up for llama3.2 and nomic

JdFSilva
JdFSilva approved these changes Nov 6, 2024
View reviewed changes
labs/embeddings/vectorizers/chunk_vectorizer.py Outdated Show resolved Hide resolved
labs/tasks/llm.py Outdated Show resolved Hide resolved
kenvontucky
kenvontucky reviewed Nov 6, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@jfrverdasca
Fix readme.md and typo
3b2d749 
* Readme now have steps to run OpenAI or Local LLM model
* Fix typo in embeddings word
@jfrverdasca jfrverdasca merged commit 09fe089 into main Nov 6, 2024
1 check passed
@jfrverdasca jfrverdasca deleted the 132/llama3.2+nomic branch November 6, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JdFSilva JdFSilva JdFSilva approved these changes

@kenvontucky kenvontucky kenvontucky approved these changes

Assignees

@jfrverdasca jfrverdasca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfrverdasca @kenvontucky @JdFSilva