fix: Stop tickers

runningnoodle · Jan 27, 2021 · 8867f77 · 8867f77
1 parent 6f2f361
commit 8867f77
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/cmd/updates.go b/cmd/updates.go
@@ -34,6 +34,8 @@ func checkUpdates(curVersion string, interval time.Duration, app *App) {
 	curVersion = reSemver.ReplaceAllString(curVersion, "")
 	time.Sleep(time.Second * 1)
 	ticker := time.NewTicker(interval)
+	defer ticker.Stop()
+
 	for ; true; <-ticker.C {
 		resp, err := http.Get(updateCheckURL)
 		if err != nil {

diff --git a/internal/manager/manager.go b/internal/manager/manager.go
@@ -348,6 +348,8 @@ func (m *Manager) Close() {
 // for campaigns to process and dispatches them to the manager.
 func (m *Manager) scanCampaigns(tick time.Duration) {
 	t := time.NewTicker(tick)
+	defer t.Stop()
+
 	for {
 		select {
 		// Periodically scan the data source for campaigns to process.