Update fladle options #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelpasterz
force-pushed
the
update-fladle-options
branch
from
727147f to
dd1758e
Compare
|
Hey @runningcode, please, take a look. |
This was referenced Jan 18, 2021
runningcode
requested changes
Jan 18, 2021
pawelpasterz
force-pushed
the
update-fladle-options
branch
from
dd1758e to
c9d2749
Compare
|
I've updated my branch with the latest master changes :) |
runningcode
reviewed
Jan 19, 2021
| "patch.0300110.com.example.android.obb", | ||
| "patch.0300111.com.example.android.obb" | ||
| ] | ||
| testTargetsForShard = [ |
There was a problem hiding this comment.
nice, thanks for adding this. however, i think it is missing in the kotlin sample.
There was a problem hiding this comment.
Ignore this comment, the sample configuration has only a groovy version.
|
I really appreciate this. I'm going to merge this in. If you get the chance could you also add the kotlin sample configuration and add this to the release notes under unreleased? |
|
Buildscan url for run 495726822 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update fladle with newly added options in flank:
grant-permissionstypescenario-labelsscenario-numbersobb-filesobb-namestest-targets-for-shardfail-fast