Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-detect apk path is not respected if multiple variants configured in configs #60

Open
witchlock opened this issue Jun 28, 2019 · 4 comments

Comments

@witchlock
Copy link

witchlock commented Jun 28, 2019

fladle {
    serviceAccountCredentials(testLabApiKey)

    devices = [
        new Device("Pixel2", 28, null, null)
    ]    

    configs {
        one {
            variant = "one-debug"            
        }
        two {
            variant = "two-debug"            
        }
    }
}

Running runFlankOne or runFlankTwo is expected to get the right app and test path however it will choose a random variant during auto-detection

@runningcode
Copy link
Owner

Hey, interesting bug. I'm not sure there is any mapping or guarantee between the configs and the build variants. If you set the path explicitly does it work?

What would be the expected behavior of detecting and matching configs and variants?

@runningcode
Copy link
Owner

Sorry it took so long to look at this bug. This feature isn't supported. I could build it if needed, but maybe additionalTestApks is a better option? https://runningcode.github.io/fladle/configuration/#additionaltestapks

runningcode added a commit that referenced this issue Apr 2, 2021
Fixes #233

First stab at #60 but does not fix it since it is impossible to know whether or not the root is configured already.
@runningcode
Copy link
Owner

Hey sorry this took a while to get a real response. I took a first stab at this and realized it is impossible to know if the variants should auto-detect the apk since they will already have the apk set and configured from the root.

runningcode added a commit that referenced this issue Apr 5, 2021
Fixes #233

First stab at #60 but does not fix it since it is impossible to know whether or not the root is configured already.
@juliocbcotta
Copy link

juliocbcotta commented Aug 9, 2021

So, is it not possible to have the variant configured in the configs block?

I have a small project here where it does not select the right apks.

wzieba added a commit to wordpress-mobile/WordPress-Android that referenced this issue Jul 31, 2024
Setting `variant` under `configs` doesn't seem to work: runningcode/fladle#60
wzieba added a commit to wordpress-mobile/WordPress-Android that referenced this issue Aug 1, 2024
Setting `variant` under `configs` doesn't seem to work: runningcode/fladle#60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants