Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for EventCallback #390

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

emorell96
Copy link
Contributor

Added support for EventCallback, in adition to the already existing support for Action.

This allows for a better support of Blazor components like wrapping the maps in custom Razor components where EventCallbacks can be exposed as parameters and the use of async methods is transparent.

I am also trying to move all the magic strings into a single c# file.

…ods used.

Created new files to hold the different kind of extensions. not a single file with thousands of lines.
…w the integration with blazor

updated the server side demo with this update
…undreds of magic strings in the code, but instead to have them in a single file.
@valentasm1
Copy link
Collaborator

This looks big. Sorry but it will take time. Try review at most in week or two.

@emorell96
Copy link
Contributor Author

Take your time, I still need to move all the strings into a single file (that's why it's a draft). The EventCallback part is bit more complex since I had to create a few new methods to avoid using reflection and object but instead sticking to generics.

@Nickztar
Copy link
Contributor

This is a interesting solution, I like that fact that methods can now be async without the annoying part of async void etc.

wrapping the maps in custom Razor components where EventCallbacks can be exposed as parameters This sounds like a good feature, I did something similar with the new AdvancedMarkerComponents that were recently added. Maybe we should add some examples of such features to this project so that it doesn't go unnoticed 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants