chore: address fix linter findings #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginglis13
changed the title
Address all linter findings, including ignoring gosec warnings about auditing the use of unsafe pointers in pkg/winutil/run_windows.go Signed-off-by: Gavin Inglis <[email protected]>
1 task
vsiravar
approved these changes
Oct 6, 2023
pendo324
approved these changes
Oct 6, 2023
ginglis13
added a commit
that referenced
this pull request
Oct 12, 2023
Issue #, if available: *Description of changes:* - Adds a workflow step to run e2e tests on the Windows runner. - Adds script for code gen on Windows - Increase e2e test timeouts to 180m - linting corrections in #607 - fix some other lints since rebasing - `go mod tidy` - install SOCI as systemd unit; on Windows, starting as background process in script was still started in foreground, resulting in termination after script completion - fix config test to use LOCALAPPDATA *Testing done:* - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Gavin Inglis <[email protected]>
vsiravar
pushed a commit
that referenced
this pull request
Oct 17, 2023
Issue #, if available: *Description of changes:* Address all linter findings, including ignoring gosec warnings about auditing the use of unsafe pointers in pkg/winutil/run_windows.go https://securego.io/docs/rules/g103.html *Testing done:* `make lint` - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Gavin Inglis <[email protected]>
vsiravar
pushed a commit
that referenced
this pull request
Oct 17, 2023
Issue #, if available: *Description of changes:* - Adds a workflow step to run e2e tests on the Windows runner. - Adds script for code gen on Windows - Increase e2e test timeouts to 180m - linting corrections in #607 - fix some other lints since rebasing - `go mod tidy` - install SOCI as systemd unit; on Windows, starting as background process in script was still started in foreground, resulting in termination after script completion - fix config test to use LOCALAPPDATA *Testing done:* - [x] I've reviewed the guidance in CONTRIBUTING.md By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Gavin Inglis <[email protected]>
vsiravar
pushed a commit
that referenced
this pull request
Oct 17, 2023
Issue #, if available: *Description of changes:* Address all linter findings, including ignoring gosec warnings about auditing the use of unsafe pointers in pkg/winutil/run_windows.go https://securego.io/docs/rules/g103.html *Testing done:* `make lint` - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Gavin Inglis <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]>
vsiravar
pushed a commit
that referenced
this pull request
Oct 17, 2023
Issue #, if available: *Description of changes:* - Adds a workflow step to run e2e tests on the Windows runner. - Adds script for code gen on Windows - Increase e2e test timeouts to 180m - linting corrections in #607 - fix some other lints since rebasing - `go mod tidy` - install SOCI as systemd unit; on Windows, starting as background process in script was still started in foreground, resulting in termination after script completion - fix config test to use LOCALAPPDATA *Testing done:* - [x] I've reviewed the guidance in CONTRIBUTING.md By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Gavin Inglis <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Address all linter findings, including ignoring gosec warnings about auditing the use of unsafe pointers in pkg/winutil/run_windows.go
https://securego.io/docs/rules/g103.html
Testing done:
make lintLicense Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.