ci: pin actions #605
Merged
ci: pin actions #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Alvarez <[email protected]>
austinvazquez
approved these changes
Oct 5, 2023
vsiravar
approved these changes
Oct 5, 2023
vsiravar
pushed a commit
that referenced
this pull request
Oct 17, 2023
Issue #, if available:
*Description of changes:*
- Pinned all actions to commit SHAs
- Just used the latest available version
- Dependabot should actually update the version comment too, thanks to
[this
feature](dependabot/dependabot-core#4691),
which is pretty neat
- `Homebrew/actions/setup-homebrew` isn't really "vended" and the
recommendation is to just use the latest master commit of the repo,
which is why the version name just says "master"
- `WyriHaximus/github-action-get-previous-tag` hasn't been updated in a
while and the functionality doesn't seem that hard to replicate on our
own. Might be good to remove it in the future
*Testing done:*
- [x] I've reviewed the guidance in CONTRIBUTING.md
#### License Acceptance
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Signed-off-by: Justin Alvarez <[email protected]>
vsiravar
pushed a commit
that referenced
this pull request
Oct 17, 2023
Issue #, if available:
*Description of changes:*
- Pinned all actions to commit SHAs
- Just used the latest available version
- Dependabot should actually update the version comment too, thanks to
[this
feature](dependabot/dependabot-core#4691),
which is pretty neat
- `Homebrew/actions/setup-homebrew` isn't really "vended" and the
recommendation is to just use the latest master commit of the repo,
which is why the version name just says "master"
- `WyriHaximus/github-action-get-previous-tag` hasn't been updated in a
while and the functionality doesn't seem that hard to replicate on our
own. Might be good to remove it in the future
*Testing done:*
- [x] I've reviewed the guidance in CONTRIBUTING.md
#### License Acceptance
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Vishwas Siravara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Homebrew/actions/setup-homebrewisn't really "vended" and the recommendation is to just use the latest master commit of the repo, which is why the version name just says "master"WyriHaximus/github-action-get-previous-taghasn't been updated in a while and the functionality doesn't seem that hard to replicate on our own. Might be good to remove it in the futureTesting done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.