ci: add GOOS to golangci-lint #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2023 16:16
Signed-off-by: Vishwas Siravara <[email protected]>
Signed-off-by: Vishwas Siravara <[email protected]>
Comment on lines
+358
to
+359
| env GOOS=windows golangci-lint run | ||
| env GOOS=darwin golangci-lint run |
There was a problem hiding this comment.
+1, I'm going to steal this for my other projects. :)
austinvazquez
approved these changes
Oct 3, 2023
ginglis13
approved these changes
Oct 3, 2023
pendo324
approved these changes
Oct 3, 2023
vsiravar
added a commit
that referenced
this pull request
Oct 17, 2023
Issue #, if available: Add GOOS to golangci-lint. Currently the golangci-lint runs on ubuntu. *Description of changes:* - Change target lint in makefile to run linter for both windows and macOS. - Update ci.yaml to lint on macOS and windows github hosted runners. *Testing done:* Makefile changes validated. - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Vishwas Siravara <[email protected]> Co-authored-by: Vishwas Siravara <[email protected]>
vsiravar
added a commit
that referenced
this pull request
Oct 17, 2023
Issue #, if available: Add GOOS to golangci-lint. Currently the golangci-lint runs on ubuntu. *Description of changes:* - Change target lint in makefile to run linter for both windows and macOS. - Update ci.yaml to lint on macOS and windows github hosted runners. *Testing done:* Makefile changes validated. - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Vishwas Siravara <[email protected]> Co-authored-by: Vishwas Siravara <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Add GOOS to golangci-lint. Currently the golangci-lint runs on ubuntu.
Description of changes:
Change target lint in makefile to run linter for both windows and macOS.
Update ci.yaml to lint on macOS and windows github hosted runners.
Testing done:
Makefile changes validated.
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.