Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes css list substitution bug #76

Merged
merged 1 commit into from Dec 27, 2019
Merged

Fixes css list substitution bug #76

merged 1 commit into from Dec 27, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 23, 2019

If you had a css list and the last item was a template, then the substituter would incorrectly replace it with $_:_____, thinking it was a full key/value replacement. This was because it didn't search past the beginning of the list to look for the colon (:) character. To fix this, I modified the regex for the previous colon to search anything that isn't a semi-colon or left curly. This way it can find the colon and properly replace with _______.

This addresses an issue I posted: #72

@runem
Copy link
Owner

runem commented Dec 27, 2019

Thank you so much for this PR, and thanks for adding CSS substitution tests 🎉
It looks great!

@runem runem merged commit f7ffdb3 into runem:master Dec 27, 2019
@runem
Copy link
Owner

runem commented Dec 27, 2019

Until this PR been published you would be able to download and install the dev build of vscode lit-plugin from here 👍

@ghost
Copy link
Author

ghost commented Feb 24, 2020

@runem Any plans for a new release? Our team was hoping to integrate the above changes into our tools without having to switch to our fork, but not rush.

@runem
Copy link
Owner

runem commented Feb 25, 2020

Sorry, lately I have been investing my time in the performance refactor branch of lit-analyzer so I haven't come around to finish testing and publish the code on master (30 commits to be published) :-)

However, I have a couple of times been thinking about publishing a new version of master, so now might be the time to do it. You can expect it to be published within a week. I'll keep you updated if the plan changes (the plan could be changed if the tests fail) 👍

@runem
Copy link
Owner

runem commented Mar 4, 2020

@dgoogles I have now published version 1.1.10 which includes the fix 🎉
Thank you so much for this PR, I really appreciate it!

@ghost
Copy link
Author

ghost commented Mar 5, 2020

@runem Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants