Update web-component-analyzer dependency to fix ts5.x support #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This better matches the repo's current formatting
typescript 5.x removed a few deprecated methods, one of which we depended on inside WCA. That has since been fixed over in the WCA repo. This change is to now bump our dependency of WCA so we pull the fix in. Meanwhile, typescript has also been updated to match the same semver as what WCA depends on (otherwise we get type mismatches when passing `SourceFile` objects around).
|
Weird that the vscode downloader fails on windows with Node >16, but this modernizes the rest of the tests' node versions |
rictic
approved these changes
Jun 14, 2023
|
Thanks for your PR - can confirm that using Thanks you! |
|
yup we still need to publish the new version of the vscode extension, so that will still have the problems i think for now but peter is looking into it so should be up soon great to know the CLI part works though 🙏 |
|
Sorry it took a bit of extra time, but the VSCode extension has now been
released!
…On Fri, Jun 16, 2023, 4:18 AM James Garbutt ***@***.***> wrote:
yup we still need to publish the new version of the vscode extension, so
that will still have the problems i think for now
but peter is looking into it so should be up soon
great to know the CLI part works though 🙏
—
Reply to this email directly, view it on GitHub
<#305 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAM65J2QIVVITIG7O4ZOLXLQ6GRANCNFSM6AAAAAAZE4UQQM>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix the various problems people are having
cc @rictic
FYI i couldn't write an extra test that fails before this change as i'd need to change the repo's typescript to 5.x, and that breaks the build thanks to a mismatch of types
we could just publish a prerelease and test it manually
let me know what you think