aria-haspopup no-incompatible-type-binding false alarm #175
Conversation
* Updated underlying vscode-web-customdata that exposes the type for aria-haspopup. * Added test to make sure setting a non-boolean value is correct.
|
@justinfagnani @43081j Any chance you can have a look at this? |
packages/lit-analyzer/test/rules/no-incompatible-type-binding.ts
Outdated
Show resolved
Hide resolved
* Removed custom rule since we are not testing boolean attributes.
|
@joekukish LGTM, thanks! I had landed a change to the no-incompatible-type-binding test so there's a conflict. Can you merge or rebase? |
# Conflicts: # packages/lit-analyzer/package.json
|
@justinfagnani I've rebased this branch and resolved conflicts. Please have a look! |
|
Thanks @joekukish ! One last thing - we need a changelog entry for this. |
|
👋 @joekukish @justinfagnani We just ran across this issue in making some updates to https://github.com/ithaka/pharos and I was wondering if there was any update here? Would be happy to pick up the mantle to get this fix in the next version if that would be helpful, but hate to take something over as it looks like it's just a missing changelog that needs to be added? |
|
@brentswisher sorry this one languished. Yeah, it's just missing a changelog. I think I couldn't commit to the PR branch so would have to make a new one. @joekukish if you can, great, or @brentswisher could take this. Thanks everyone! |
|
@justinfagnani I started looking into this, and found it appears to be working in the source code on the latest version of master. I see the package is actively maintained with updates in the last few weeks/months, but a new release hasn't been cut since July of 2020. Am I misunderstanding something, it seems like there is a lot or work that has been done that isn't getting packaged up for consumers? |
|
Hey @justinfagnani, I think @brentswisher and I could work on getting a fresh PR together with a changelog. Do you think that will position you well for a new release? If there're other things outstanding we might be able to help as well; let us know. |
|
Release v2.0.1 looks to have landed a fix for this as well, this PR can likely be closed now. |
Fixes #142
aria-haspopup.