Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-complex-attribute-binding: take converters into consideration #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Jul 25, 2020

Fixes #123

like i mention in the issue, i might add on to this to make no-incompatible-type-binding also take them into account.

let me know if you think thats sensible

@runem
Copy link
Owner

runem commented Jul 26, 2020

I see that you needed to manually run prettier. It seems like lint-staged with husky doesn't run for each commit on your machine. Do you have any idea why this is so?

@43081j
Copy link
Contributor Author

43081j commented Jul 26, 2020

Good question. I just commit via git through a terminal so I would have expected husky to be fine.

I'll have a look tomorrow and see if there's any obvious reason it isn't

@43081j
Copy link
Contributor Author

43081j commented Aug 29, 2020

@runem is this still a valid PR? could we try get it merged if its still needed. i can catch it up, presumably its pretty far behind by now

@43081j 43081j force-pushed the complex-converter branch from f0c6be4 to 956006b Compare August 29, 2020 18:06
@43081j 43081j force-pushed the complex-converter branch from 956006b to afb5d2b Compare May 9, 2021 11:31
@43081j 43081j force-pushed the complex-converter branch from afb5d2b to 91ebc41 Compare May 30, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lit-plugin(no-complex-attribute-binding) when property has a converter
2 participants