Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode-lit-plugin] Typescript 5.1 Missing import warning for <my-element> doesn't work #313

Closed
herberthobregon opened this issue Jun 29, 2023 · 5 comments
Closed

[vscode-lit-plugin] Typescript 5.1 Missing import warning for <my-element> doesn't work #313

herberthobregon opened this issue Jun 29, 2023 · 5 comments

Comments

@herberthobregon
Copy link

@rictic Missing import for still doesn't work with latest typescript version
@herberthobregon herberthobregon changed the title [vscode-lit-plugin] Typescript 5.1 Missing import for <my-element> doesn't work [vscode-lit-plugin] Typescript 5.1 Missing import warning for <my-element> doesn't work Jul 10, 2023
@abenz1267
Copy link

abenz1267 commented Jul 17, 2023 •
edited
Loading

not only that, i think no linting is working. f.e. having css with cur: ointer should result in a warning/error as well. It doesnt!

Typescript 4.9.3 is the last official version that works.

peschee added a commit to keycloak-competence-center/keycloak-signature that referenced this issue Sep 20, 2023
@peschee
Typescript 4.9.3 is the last official version that works with lit-ana…
6183c4d 
…lyzer

@see runem/lit-analyzer#313
@Galbrain
Copy link

Me and my colleagues the same issue still.

@herberthobregon
Copy link
Author

Currently I use 4.7.4. I'm waiting for this problem to be solved

@benjamind
Copy link
Contributor

This is also causing problem for us on some rather large projects at Adobe....Is this plugin pretty much abandoned at this point for the work going on in the main lit project or is there hope for a fix here?

@benjamind
Copy link
Contributor

Reproduction here: https://github.com/benjamind/vscode-lit-plugin-313-repro

Seems to be related to tsconfig.json module setting being present.

benjamind added a commit to benjamind/lit-analyzer that referenced this issue Dec 7, 2023
@benjamind
Fixes runem#313 by correctly using projects moduleResolution strategy…
b492554 
… if provided
@rictic rictic closed this as completed in 0b8c8ba Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@benjamind @herberthobregon @abenz1267 @Galbrain