Fix Adyen#23 PW-2747 Improve exception logging

runelaenen · Aug 11, 2020 · d54d36d · wannevancamp · Aug 11, 2020 · d54d36d
1 parent d8fe558
commit d54d36d
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 8 deletions.
diff --git a/Components/Adyen/PaymentMethodService.php b/Components/Adyen/PaymentMethodService.php
@@ -88,7 +88,14 @@ public function getPaymentMethods(
         try {
             $paymentMethods = $checkout->paymentMethods($requestParams);
         } catch (AdyenException $e) {
-            $this->logger->critical($e);
+            $this->logger->critical('Adyen Exception', [
+				'message' => $e->getMessage(),
+            	'file' => $e->getFile(),
+				'line' => $e->getLine(),
+				'statuc' => $e->getStatus(),
+				'errorType' => $e->getErrorType(),
+				'status' => $e->getStatus()
+			]);
             return [];
         }
 

diff --git a/Components/NotificationProcessor.php b/Components/NotificationProcessor.php
@@ -136,7 +136,11 @@ private function process(Notification $notification)
             } catch (\Exception $exception) {
                 $status = NotificationStatus::STATUS_FATAL;
                 $this->logger->notice('General Exception', [
-                    'exception' => $exception,
+                    'exception' => [
+                    	'message' => $exception->getMessage(),
+						'file' => $exception->getFile(),
+						'line' => $exception->getLine()
+					],
                     'notificationId' => $notification->getId()
                 ]);
                 yield new NotificationProcessorFeedback(

diff --git a/Components/ShopwareVersionCheck.php b/Components/ShopwareVersionCheck.php
@@ -45,7 +45,11 @@ public function isHigherThanShopwareVersion(string $shopwareVersion): bool
                 list($composerVersion, $sha) = explode('@', Versions::getVersion('shopware/shopware'));
                 $version = $composerVersion;
             } catch (OutOfBoundsException $ex) {
-                $this->logger->error($ex);
+                $this->logger->error('OutOfBoundsException', [
+					'message' => $ex->getMessage(),
+					'file' => $ex->getFile(),
+					'line' => $ex->getLine()
+				]);
             }
         }
 

diff --git a/Controllers/Frontend/Adyen.php b/Controllers/Frontend/Adyen.php
@@ -93,12 +93,17 @@ public function ajaxDoPaymentAction()
                     'content' => $paymentInfo
                 ]
             ));
-        } catch (\Adyen\AdyenException $e) {
-            $this->logger->debug($e);
+        } catch (\Adyen\AdyenException $ex) {
+            $this->logger->debug('AdyenException during doPayment', [
+				'message' => $ex->getMessage(),
+				'file' => $ex->getFile(),
+				'line' => $ex->getLine()
+			]);
+
             $this->Response()->setBody(json_encode(
                 [
                     'status' => 'error',
-                    'content' => $e->getMessage()
+                    'content' => $ex->getMessage()
                 ]
             ));
         }

diff --git a/Subscriber/BackendConfigSubscriber.php b/Subscriber/BackendConfigSubscriber.php
@@ -67,8 +67,12 @@ public function onBackendConfig(\Enlight_Event_EventArgs $args)
         ) {
             try {
                 $this->originKeysService->generateAndSave();
-            } catch (AdyenException $e) {
-                $this->logger->error($e);
+            } catch (AdyenException $ex) {
+                $this->logger->error('AdyenException on Backend Config', [
+					'message' => $ex->getMessage(),
+					'file' => $ex->getFile(),
+					'line' => $ex->getLine()
+				]);
             }
 
             if ($this->shopwareVersionCheck->isHigherThanShopwareVersion('v5.5.6')) {